Update RankingTrainer usage and Remove BLAS #300
Merged
+93
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rofuyu
reviewed
Oct 11, 2024
.github/build_pypi_wheel.sh
Outdated
| echo "$PLAT not supported." | ||
| exit 1 | ||
| fi | ||
| $PIP install 'setuptools' wheel twine auditwheel |
There was a problem hiding this comment.
do we still need the single quotes here?
There was a problem hiding this comment.
Thanks for the catch. Removed the single quotes in the latest commit.
rofuyu
reviewed
Oct 11, 2024
pecos/core/utils/matrix.hpp
Outdated
| template<> inline float scal(ptrdiff_t *len, float *a, float *x, ptrdiff_t *xinc) { return sscal_(len, a, x, xinc); } | ||
| template<typename val_type> val_type scal(ptrdiff_t *len, val_type *a, val_type *x, ptrdiff_t *xinc) { | ||
| for (ptrdiff_t idx = 0; idx < *len; idx++) { | ||
| *x = (*x) * (*a); |
There was a problem hiding this comment.
Thanks for the catch. Fixed the indentation issue in the latest commit.
rofuyu
reviewed
Oct 11, 2024
setup.py
Outdated
| extra_compile_args=["-fopenmp", "-O3", "-std=c++17"] + manual_compile_args, | ||
| extra_link_args=['-Wl,--no-as-needed', f"-Wl,-rpath,{':'.join(blas_dir)}"] | ||
| extra_link_args=['-Wl,--no-as-needed', f"-Wl,-rpath"] |
There was a problem hiding this comment.
we might be able to remove the rpath path.
There was a problem hiding this comment.
Thanks for the suggestion. We removed the extra_link_args in the latest commit.
OctoberChang
force-pushed
the
reranker-dev
branch
2 times, most recently
from
035874f
to
017cd97
Compare
rofuyu
approved these changes
Oct 14, 2024
OctoberChang
force-pushed
the
reranker-dev
branch
4 times, most recently
from
32727d4
to
018a3dc
Compare
OctoberChang
force-pushed
the
reranker-dev
branch
from
018a3dc
to
e67554d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.